Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pref: add help menu #411

Merged
merged 6 commits into from
Feb 19, 2024
Merged

pref: add help menu #411

merged 6 commits into from
Feb 19, 2024
+26 −0

Conversation

AkaShark
Copy link
Collaborator

No description provided.

CanglongCl
CanglongCl previously approved these changes Feb 18, 2024
View reviewed changes
@AkaShark AkaShark requested a review from CanglongCl February 18, 2024 14:56
Jerry23011
Jerry23011 approved these changes Feb 18, 2024
View reviewed changes
Copy link
Collaborator

@Jerry23011 Jerry23011 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could also add Easydict Help there later, it's just that Apple's current help book framework is very annoying to implement

@AkaShark
Copy link
Collaborator Author

LGTM. We could also add Easydict Help there later, it's just that Apple's current help book framework is very annoying to implement

okay, I will implement it in the next PR.

@tisfeng tisfeng merged commit 84cdfb1 into tisfeng:dev Feb 19, 2024
5 checks passed
@AkaShark AkaShark mentioned this pull request Feb 22, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlpsong phlpsong phlpsong approved these changes

@Jerry23011 Jerry23011 Jerry23011 approved these changes

@CanglongCl CanglongCl CanglongCl approved these changes

@tisfeng tisfeng tisfeng approved these changes

@NeverAgain11 NeverAgain11 Awaiting requested review from NeverAgain11

@choykarl choykarl Awaiting requested review from choykarl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AkaShark @tisfeng @CanglongCl @Jerry23011 @phlpsong